[
https://issues.apache.org/jira/browse/PARQUET-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782483#comment-17782483
]
ASF GitHub Bot commented on PARQUET-2372:
-----------------------------------------
ConeyLiu commented on code in PR #1183:
URL: https://github.com/apache/parquet-mr/pull/1183#discussion_r1381384663
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java:
##########
@@ -666,6 +658,8 @@ private void nullifyColumn(ColumnDescriptor descriptor,
long totalChunkValues = chunk.getValueCount();
int dMax = descriptor.getMaxDefinitionLevel();
+ PageReadStore pageReadStore = reader.readRowGroup(blockIndex);
Review Comment:
Only get the `PageReadStore` when needed.
> Avoid unnecessary reading of RowGroup data during rewriting
> -----------------------------------------------------------
>
> Key: PARQUET-2372
> URL: https://issues.apache.org/jira/browse/PARQUET-2372
> Project: Parquet
> Issue Type: Improvement
> Reporter: Xianyang Liu
> Priority: Major
>
> This patch aims to reduce the unnecessary RowGroup data reading during
> rewriting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
