[
https://issues.apache.org/jira/browse/PARQUET-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784139#comment-17784139
]
ASF GitHub Bot commented on PARQUET-2371:
-----------------------------------------
amousavigourabi commented on PR #1181:
URL: https://github.com/apache/parquet-mr/pull/1181#issuecomment-1802300343
@gszadovszky, the issue at hand was not that adding methods to already
existing interfaces caused failures. As you noted, this would be perfectly fine
and expected behaviour. Instead, japicmp failed on wholly new interfaces (see
`org.apache.parquet.conf.ParquetConfiguration`), and new method implementations
(see `org.apache.parquet.hadoop.thrift.TBaseWriteSupport`), under quite a vague
motivation `CLASS_GENERIC_TEMPLATE_CHANGED`.
> Resolve japicmp failure for CI
> ------------------------------
>
> Key: PARQUET-2371
> URL: https://issues.apache.org/jira/browse/PARQUET-2371
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Atour Mousavi Gourabi
> Assignee: Atour Mousavi Gourabi
> Priority: Major
> Fix For: 1.14.0
>
>
> Japicmp triggers on newly added methods, which have not been changed. This is
> likely a japicmp bug. Excludes should be added for the affected classes, as
> otherwise the CI job will not run anything after the japicmp goal. See the
> discussion at https://github.com/apache/parquet-mr/pull/1141.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
