Fokko commented on code in PR #1192:
URL: https://github.com/apache/parquet-mr/pull/1192#discussion_r1391718987
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftTypeID.java:
##########
@@ -51,10 +51,15 @@ public enum ThriftTypeID {
LIST (TType.LIST, true, ListType.class),
ENUM (TType.ENUM, TType.I32, EnumType.class);
- private static ThriftTypeID[] types = new ThriftTypeID[17];
+ private static final ThriftTypeID[] types;
static {
+ types = new ThriftTypeID[18];
for (ThriftTypeID t : ThriftTypeID.values()) {
- types[t.thriftType] = t;
+ if (t.thriftType == -1) {
Review Comment:
I first thought it was because some class was moved, but this broke the
initialization of the class:
https://github.com/apache/thrift/blob/master/lib/java/src/main/java/org/apache/thrift/protocol/TType.java#L39-L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
