[
https://issues.apache.org/jira/browse/PARQUET-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785670#comment-17785670
]
ASF GitHub Bot commented on PARQUET-2344:
-----------------------------------------
Fokko commented on code in PR #1192:
URL: https://github.com/apache/parquet-mr/pull/1192#discussion_r1391718987
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftTypeID.java:
##########
@@ -51,10 +51,15 @@ public enum ThriftTypeID {
LIST (TType.LIST, true, ListType.class),
ENUM (TType.ENUM, TType.I32, EnumType.class);
- private static ThriftTypeID[] types = new ThriftTypeID[17];
+ private static final ThriftTypeID[] types;
static {
+ types = new ThriftTypeID[18];
for (ThriftTypeID t : ThriftTypeID.values()) {
- types[t.thriftType] = t;
+ if (t.thriftType == -1) {
Review Comment:
I first thought it was because some class was moved, but this broke the
initialization of the class:
https://github.com/apache/thrift/blob/master/lib/java/src/main/java/org/apache/thrift/protocol/TType.java#L39-L40
> Bump to Thirft 0.19.0
> ---------------------
>
> Key: PARQUET-2344
> URL: https://issues.apache.org/jira/browse/PARQUET-2344
> Project: Parquet
> Issue Type: Bug
> Components: parquet-format, parquet-mr
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: format-2.10.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
