jatin-bhateja commented on code in PR #1186:
URL: https://github.com/apache/parquet-mr/pull/1186#discussion_r1392039836
##########
parquet-plugins/parquet-plugins-benchmarks/src/main/java/org/apache/parquet/plugins/benchmarks/ByteBitPackingVectorBenchmarks.java:
##########
@@ -38,48 +40,60 @@
*/
@State(Scope.Benchmark)
-@BenchmarkMode(Mode.AverageTime)
+@BenchmarkMode(Mode.Throughput)
@Warmup(iterations = 1, batchSize = 100000)
@Measurement(iterations = 1, batchSize = 100000)
-@OutputTimeUnit(TimeUnit.MILLISECONDS)
+@OutputTimeUnit(TimeUnit.SECONDS)
+@Fork(jvmArgsPrepend = {"--add-modules=jdk.incubator.vector"})
public class ByteBitPackingVectorBenchmarks {
-
/**
* The range of bitWidth is 1 ~ 32, change it directly if test other
bitWidth.
*/
- private static final int bitWidth = 7;
- private static final int outputValues = 1024;
- private final byte[] input = new byte[outputValues * bitWidth / 8];
- private final int[] output = new int[outputValues];
- private final int[] outputVector = new int[outputValues];
+ @Param({"1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13",
"14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26",
"27", "28", "29", "30", "31" })
Review Comment:
Good observation, I am not aware if Param accepts ranges as of now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
