ConeyLiu commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1403534057
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndexBuilder.java:
##########
@@ -116,11 +137,28 @@ private OffsetIndexBuilder() {
* @param rowCount
* the number of rows in the page
*/
+ @Deprecated
public void add(int compressedPageSize, long rowCount) {
- add(previousOffset + previousPageSize, compressedPageSize,
previousRowIndex + previousRowCount);
+ add(compressedPageSize, rowCount, Optional.empty());
+ }
+
+ /**
+ * Adds the specified parameters to this builder. Used by the writers to
building up {@link OffsetIndex} objects to be
+ * written to the Parquet file.
+ *
+ * @param compressedPageSize
+ * the size of the page (including header)
+ * @param rowCount
+ * the number of rows in the page
+ * @param unencodedDataBytes
+ * the number of bytes of unencoded data of BYTE_ARRAY type
+ */
+ public void add(int compressedPageSize, long rowCount, Optional<Long>
unencodedDataBytes) {
+ add(previousOffset + previousPageSize, compressedPageSize,
previousRowIndex + previousRowCount, unencodedDataBytes);
previousRowCount = rowCount;
}
+
Review Comment:
blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
