[
https://issues.apache.org/jira/browse/PARQUET-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789190#comment-17789190
]
ASF GitHub Bot commented on PARQUET-2261:
-----------------------------------------
ConeyLiu commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1403537889
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java:
##########
@@ -316,7 +346,14 @@ private int toIntWithCheck(long size) {
return (int)size;
}
- private void mergeColumnStatistics(Statistics<?> statistics) {
+ private void mergeColumnStatistics(Statistics<?> statistics,
SizeStatistics sizeStatistics) {
+ Preconditions.checkState(totalSizeStatistics != null, "Aggregate size
statistics should not be null");
Review Comment:
If the `totalSizeStatistics` is set as final. The checking here is not
needed anymore.
> [Format] Add statistics that reflect decoded size to metadata
> -------------------------------------------------------------
>
> Key: PARQUET-2261
> URL: https://issues.apache.org/jira/browse/PARQUET-2261
> Project: Parquet
> Issue Type: New Feature
> Components: parquet-format
> Reporter: Micah Kornfield
> Assignee: Micah Kornfield
> Priority: Major
> Fix For: format-2.10.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
