[ 
https://issues.apache.org/jira/browse/PARQUET-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789183#comment-17789183
 ] 

ASF GitHub Bot commented on PARQUET-2261:
-----------------------------------------

ConeyLiu commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1403533624


##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndexBuilder.java:
##########
@@ -80,11 +90,22 @@ public void add(int compressedPageSize, long rowCount) {
     @Override
     public void add(long offset, int compressedPageSize, long rowCount) {
     }
+
+    @Override
+    public OffsetIndex build() {

Review Comment:
   Why add these two changes? Does this perform as same as before?





> [Format] Add statistics that reflect decoded size to metadata
> -------------------------------------------------------------
>
>                 Key: PARQUET-2261
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2261
>             Project: Parquet
>          Issue Type: New Feature
>          Components: parquet-format
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Major
>             Fix For: format-2.10.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to