wgtmac commented on code in PR #1203:
URL: https://github.com/apache/parquet-mr/pull/1203#discussion_r1405536183
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java:
##########
@@ -303,6 +303,32 @@ public ParquetWriter(Path file, Configuration conf,
WriteSupport<T> writeSupport
int maxPaddingSize,
ParquetProperties encodingProps,
FileEncryptionProperties encryptionProperties) throws IOException {
+ this(
+ file,
+ mode,
+ writeSupport,
+ compressionCodecName,
+ new CodecFactory(conf, encodingProps.getPageSizeThreshold()),
+ rowGroupSize,
+ validating,
+ conf,
+ maxPaddingSize,
+ encodingProps,
+ encryptionProperties);
+ }
+
+ ParquetWriter(
+ OutputFile file,
Review Comment:
It seems the indentation of constructor is 4 spaces elsewhere.
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java:
##########
@@ -321,17 +347,17 @@ public ParquetWriter(Path file, Configuration conf,
WriteSupport<T> writeSupport
encodingProps.getPageWriteChecksumEnabled(), encryptionProperties);
fileWriter.start();
- this.codecFactory = new CodecFactory(conf,
encodingProps.getPageSizeThreshold());
+ this.codecFactory = codecFactory;
CompressionCodecFactory.BytesInputCompressor compressor =
codecFactory.getCompressor(compressionCodecName);
this.writer = new InternalParquetRecordWriter<T>(
- fileWriter,
- writeSupport,
- schema,
- writeContext.getExtraMetaData(),
- rowGroupSize,
- compressor,
- validating,
- encodingProps);
+ fileWriter,
Review Comment:
Could you please revert the irrelevant style change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
