[
https://issues.apache.org/jira/browse/PARQUET-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790917#comment-17790917
]
ASF GitHub Bot commented on PARQUET-2396:
-----------------------------------------
zhangjiashen commented on code in PR #1219:
URL: https://github.com/apache/parquet-mr/pull/1219#discussion_r1408788644
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java:
##########
@@ -298,24 +295,22 @@ public <T extends Comparable<T>> PrimitiveIterator.OfInt
visit(NotEq<T> notEq) {
public <T extends Comparable<T>> PrimitiveIterator.OfInt visit(In<T> in) {
Set<T> values = in.getValues();
IntSet matchingIndexesForNull = new IntOpenHashSet(); // for null
- Iterator<T> it = values.iterator();
- while(it.hasNext()) {
- T value = it.next();
- if (value == null) {
- if (nullCounts == null) {
- // Searching for nulls so if we don't have null related statistics
we have to return all pages
- return IndexIterator.all(getPageCount());
- } else {
- for (int i = 0; i < nullCounts.length; i++) {
- if (nullCounts[i] > 0) {
- matchingIndexesForNull.add(i);
+ for (T value : values) {
+ if (value == null) {
Review Comment:
Nit: Let's modify the indent spaces to 2 and ensure consistency?
> Refactor `ColumnIndexBuilder`
> -----------------------------
>
> Key: PARQUET-2396
> URL: https://issues.apache.org/jira/browse/PARQUET-2396
> Project: Parquet
> Issue Type: Improvement
> Affects Versions: 1.13.1
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
