[
https://issues.apache.org/jira/browse/PARQUET-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791649#comment-17791649
]
ASF GitHub Bot commented on PARQUET-2387:
-----------------------------------------
Fokko commented on code in PR #1210:
URL: https://github.com/apache/parquet-mr/pull/1210#discussion_r1410732198
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/BufferedProtocolReadToWrite.java:
##########
@@ -369,7 +369,7 @@ public String toDebugString() {
ThriftField expectedField;
if ((expectedField = type.getChildById(field.id)) == null) {
handleUnrecognizedField(field, type, in);
- hasFieldsIgnored |= true;
Review Comment:
`hasFieldsIgnored |= true` equals `hasFieldsIgnored = hasFieldsIgnored ||
true` which will always return true.
> Simplify `hasFieldsIgnored` expression
> --------------------------------------
>
> Key: PARQUET-2387
> URL: https://issues.apache.org/jira/browse/PARQUET-2387
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-thrift
> Affects Versions: 1.13.1
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
