[
https://issues.apache.org/jira/browse/PARQUET-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792964#comment-17792964
]
ASF GitHub Bot commented on PARQUET-2261:
-----------------------------------------
shangxinli commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1414218649
##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java:
##########
@@ -389,7 +400,14 @@ void writePage() {
this.rowsWrittenSoFar += pageRowCount;
if (DEBUG) LOG.debug("write page");
try {
- writePage(pageRowCount, valueCount, statistics, repetitionLevelColumn,
definitionLevelColumn, dataColumn);
+ writePage(
+ pageRowCount,
+ valueCount,
+ statistics,
+ sizeStatisticsBuilder.build(),
Review Comment:
Can we have the parity of lines 406 and 407? You can use a variable in line
407
> [Format] Add statistics that reflect decoded size to metadata
> -------------------------------------------------------------
>
> Key: PARQUET-2261
> URL: https://issues.apache.org/jira/browse/PARQUET-2261
> Project: Parquet
> Issue Type: New Feature
> Components: parquet-format
> Reporter: Micah Kornfield
> Assignee: Micah Kornfield
> Priority: Major
> Fix For: format-2.10.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
