shangxinli commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1414220467
##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java:
##########
@@ -409,4 +428,14 @@ abstract void writePage(
ValuesWriter definitionLevels,
ValuesWriter values)
throws IOException;
+
+ abstract void writePage(
+ int rowCount,
+ int valueCount,
+ Statistics<?> statistics,
+ SizeStatistics sizeStatistics,
Review Comment:
There could be some confusion of the two names that sieStatistics is one
type of statistics but we are separating them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
