I agree that we should fix the issue for the release. I will send a notice to fail the vote and prepare RC1 once the fix is ready.
Thanks everyone and sorry about any inconvenience for aborting RC0. Gang On Thu, May 2, 2024 at 7:01 PM Fokko Driesprong <fo...@apache.org> wrote: > Hey everyone, > > After some testing, I'm leaning towards a -1, Unfortunately (non-binding). > > I noticed that we've introduced new classes for the ParquetConfiguration, > which is great since this will enable the projects that want to move away > from Hadoop. However, the current implementation will raise an exception if > the configuration is not passed in. See #1338 > <https://github.com/apache/parquet-mr/pull/1339> for details and also a > fix. This affects multiple projects, including Iceberg > <https://github.com/apache/iceberg/pull/10209> and Hudi > <https://github.com/trinodb/trino/pull/21802>. > > Kind regards, > Fokko > > > Op do 2 mei 2024 om 09:24 schreef Gidon Gershinsky <gg5...@gmail.com>: > > > +1 (binding) > > > > Ran the build and tests. > > > > I'm told by the Spark community they'd like to integrate the new > parquet-mr > > in Spark 4.0, so are interested in having the v1.14 as soon as possible. > > > > > > On Tue, Apr 30, 2024 at 6:26 PM Vinoo Ganesh <vinoo.gan...@gmail.com> > > wrote: > > > > > +1 (non-binding) > > > > > > Bumped to 1.14.0-SNAPSHOT in Spark and ran a few tests too > > > > > > > > > <vinoo.gan...@gmail.com> > > > > > > > > > On Tue, Apr 30, 2024 at 10:20 AM Xinli shang <sha...@uber.com.invalid> > > > wrote: > > > > > > > +1 (binding) > > > > > > > > Validated the KEY > > > > > > > > On Tue, Apr 30, 2024 at 1:18 AM Gang Wu <ust...@gmail.com> wrote: > > > > > > > > > Thank you! > > > > > > > > > > On Tue, Apr 30, 2024 at 4:16 PM Gábor Szádovszky <ga...@apache.org > > > > > > wrote: > > > > > > > > > > > By importing the KEYS file under [1] the check of the .asc file > > > passed! > > > > > > So, I went forward and updated the KEYS file under [2] with your > > new > > > > one. > > > > > > > > > > > > Giving +1 (binding) for the release > > > > > > > > > > > > Cheers, > > > > > > Gabor > > > > > > > > > > > > Gang Wu <ust...@gmail.com> ezt írta (időpont: 2024. ápr. 30., K, > > > > 9:58): > > > > > > > > > > > > > I have appended my new key to [1]. Please verify again. > However, > > I > > > > > don't > > > > > > > have the permission to update [2]. That may not be an issue as > I > > > > don't > > > > > > have > > > > > > > to permission to upload the final tarball to the svn release > > repo. > > > > > > > > > > > > > > [1] https://dist.apache.org/repos/dist/dev/parquet/KEYS > > > > > > > [2] https://dist.apache.org/repos/dist/release/parquet/KEYS > > > > > > > > > > > > > > On Tue, Apr 30, 2024 at 3:45 PM Gábor Szádovszky < > > ga...@apache.org > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Sure, please add your new public key to the referenced KEYS > > file > > > > then > > > > > > we > > > > > > > > should be good. (The previous one would still be required to > > > check > > > > > the > > > > > > > > previous releases, so do not remove it.) > > > > > > > > > > > > > > > > Gang Wu <ust...@gmail.com> ezt írta (időpont: 2024. ápr. > 30., > > K, > > > > > > 9:27): > > > > > > > > > > > > > > > > > Hi Gabor, > > > > > > > > > > > > > > > > > > Thanks for raising the issue! My original key was deleted > by > > an > > > > > > > accident > > > > > > > > > of running a shell script and cannot be recovered any > more. I > > > > have > > > > > > > > created > > > > > > > > > a new key and used it to sign the tarball. That's why it > does > > > not > > > > > > > exists > > > > > > > > in > > > > > > > > > the KEYS file. I have sent the new key to some key servers > > > > already. > > > > > > > Does > > > > > > > > > it make sense to add my new key to the KEYS file instead? > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > Gang > > > > > > > > > > > > > > > > > > On Tue, Apr 30, 2024 at 3:11 PM Gábor Szádovszky < > > > > ga...@apache.org > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi Gang, > > > > > > > > > > > > > > > > > > > > Thank you for taking care of the release! > > > > > > > > > > > > > > > > > > > > Unfortunately, the .asc check fails for me even after > > > importing > > > > > the > > > > > > > > KEYS > > > > > > > > > > file. Could you double check if you signed it with the > > > correct > > > > > key? > > > > > > > > > > No other issues were discovered, so no RC1 is required > for > > > now > > > > if > > > > > > you > > > > > > > > can > > > > > > > > > > change the .asc file for the current tarball. > > > > > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > Gabor > > > > > > > > > > > > > > > > > > > > Gang Wu <ust...@gmail.com> ezt írta (időpont: 2024. ápr. > > > 30., > > > > K, > > > > > > > > 7:45): > > > > > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > > > I propose the following RC to be released as the > official > > > > > Apache > > > > > > > > > Parquet > > > > > > > > > > > 1.14.0 release. > > > > > > > > > > > > > > > > > > > > > > The commit id is > af0740229929337e1395fd24253a4ed787df2db3 > > > > > > > > > > > * This corresponds to the tag: > apache-parquet-1.14.0-rc0 > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-mr/tree/af0740229929337e1395fd24253a4ed787df2db3 > > > > > > > > > > > > > > > > > > > > > > The release tarball, signature, and checksums are here: > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.14.0-rc0 > > > > > > > > > > > > > > > > > > > > > > You can find the KEYS file here: > > > > > > > > > > > * https://downloads.apache.org/parquet/KEYS > > > > > > > > > > > > > > > > > > > > > > Binary artifacts are staged in Nexus here: > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/ > > > > > > > > > > > > > > > > > > > > > > This release includes important changes: > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-mr/blob/parquet-1.14.x/CHANGES.md#version-1140 > > > > > > > > > > > > > > > > > > > > > > Please download, verify, and test. > > > > > > > > > > > > > > > > > > > > > > Please vote in the next 72 hours. > > > > > > > > > > > > > > > > > > > > > > [ ] +1 Release this as Apache Parquet 1.14.0 > > > > > > > > > > > [ ] +0 > > > > > > > > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > Gang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Xinli Shang > > > > > > > > > >
