Good catch Gábor! I've created PRs to fix this for future releases:
- https://github.com/apache/parquet-mr/pull/1347 - https://github.com/apache/parquet-mr/pull/1348 Kind regards, Fokko Op ma 6 mei 2024 om 08:50 schreef Gábor Szádovszky <ga...@apache.org>: > Thanks Fokko, Gang for working on this. > I have some findings: > * nit correction in the original mail: tag is apache-parquet-1.14.0-rc1 > (not apache-parquet-1.4.0-rc1) > * The CHANGES.md should have been updated with the one fix you've mentioned > (PARQUET-2465) > > Since I've never used CHANGES.md to actually check a release content, I > don't feel this issue is so crucial to fail this vote. I would let the > other voters decide. > +1 (binding) > > Gang Wu <ust...@gmail.com> ezt írta (időpont: 2024. máj. 6., H, 3:33): > > > +1 (non-binding) > > > > Verified signature, checksum and build. > > > > Thanks Fokko for doing this! Let me take care of the rest. > > > > Best, > > Gang > > > > On Mon, May 6, 2024 at 4:36 AM Fokko Driesprong <fo...@apache.org> > wrote: > > > > > Hey everyone, > > > > > > +1 (non-binding) > > > > > > - Checked against Trino and the RC1 runs cleanly > > > <https://github.com/trinodb/trino/pull/21802> > > > - Checked against Iceberg and the tests passed locally. To let the CI > > pass > > > we must upgrade Gradle, this is because Parquet ships with a new > Jackson > > > version that contains JDK21 code, but this is an issue on the Iceberg > > side > > > <https://github.com/apache/iceberg/pull/10209#issuecomment-2094939429 > >. > > > > > > Kind regards, > > > Fokko > > > > > > > > > Op vr 3 mei 2024 om 17:46 schreef Fokko Driesprong <fo...@apache.org>: > > > > > > > Hi everyone, > > > > > > > > Since Gang is enjoying a well-deserved vacation > > > > < > > https://github.com/apache/parquet-mr/pull/1342#issuecomment-2092774404 > > > >, > > > > I'm jumping in for this RC. I propose the following RC to be released > > as > > > > the official Apache Parquet 1.14.0 release. > > > > > > > > The commit ID is fe9179414906cc19b550d13d2819b4e16fddf8a1 > > > > * This corresponds to the tag: apache-parquet-1.4.0-rc1 > > > > * > > > > > > > > > > https://github.com/apache/parquet-mr/tree/fe9179414906cc19b550d13d2819b4e16fddf8a1 > > > > > > > > The release tarball, signature, and checksums are here: > > > > * > > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.14.0-rc1/ > > > > > > > > You can find the KEYS file here: > > > > * https://downloads.apache.org/parquet/KEYS > > > > > > > > Binary artifacts are staged in Nexus here: > > > > * > > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/ > > > > > > > > This release includes important changes: > > > > > > > > * > > > > > > > > > > https://github.com/apache/parquet-mr/blob/parquet-1.14.x/CHANGES.md#version-1140 > > > > > > > > Since RC0 one commit has been added: > > > > https://github.com/apache/parquet-mr/pull/1342 > > > > > > > > Please download, verify, and test. > > > > > > > > Please vote in the next 72 hours. > > > > > > > > [ ] +1 Release this as Apache Parquet 1.14.0 > > > > [ ] +0 > > > > [ ] -1 Do not release this because... > > > > > > > > Kind regards, > > > > Fokko > > > > > > > > > >
