alamb commented on code in PR #60:
URL: https://github.com/apache/parquet-site/pull/60#discussion_r1608995912
##########
content/en/_index.html:
##########
@@ -24,8 +24,8 @@
{{% /blocks/feature %}}
-{{% blocks/feature icon="fab fa-github" title="Contributions welcome!"
url="https://github.com/apache/parquet-mr"; %}}
-We do a [Pull Request](https://github.com/apache/parquet-mr/pulls)
contributions workflow on **GitHub**. New users are always welcome!
+{{% blocks/feature icon="fab fa-github" title="Contributions welcome!"
url="https://github.com/apache/parquet-java"; %}}
Review Comment:
As part of another PR perhaps we should revisit this link (perhaps it should
link to parquet-format?) as again linking to the java implementation from the
homepage might be more confusing than helpful
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can now preview the site locally on http://localhost:1313/
To create documentation for a new release of `parquet-format` create a new
<releaseNumber>.md file under `content/en/blog/parquet-format`. Please see
existing files in that directory as an example.
-To create documentation for a new release of `parquet-mr` create a new
<releaseNumber>.md file under `content/en/blog/parquet-mr`. Please see existing
files in that directory as an example.
+To create documentation for a new release of `parquet-java` create a new
<releaseNumber>.md file under `content/en/blog/parquet-java`. Please see
existing files in that directory as an example.
Review Comment:
I would personally suggest removing the discussion bout release of
`parquet-mr`/ `parquet-java` to that repo. It seems confusing to have
instructions on how to do a release from another repo in `parquet-site`
##########
content/en/docs/Overview/_index.md:
##########
@@ -18,14 +18,14 @@ The parquet-format repository hosts the official
specification of the Apache Par
As a repository focused on specification, the parquet-format repository does
not contain source code.
-### parquet-mr
+### parquet-java
Review Comment:
i agree adding a note like this would be clearer
```
The parquet-java repository(previously named `parquet-mr`) is part of the
Apache Parquet project and specifically focuses on providing Java tools for
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
