etseidl commented on code in PR #34: URL: https://github.com/apache/parquet-site/pull/34#discussion_r1644837641
########## content/en/docs/File Format/implementationstatus.md: ########## @@ -0,0 +1,101 @@ +--- +title: "Implementation status" +linkTitle: "Implementation status" +weight: 8 +--- +### Physical types + +| Data type | C++ | Java | Go | Rust | +| ----------------------------------------- | ----- | ------ | ----- | ----- | +| BOOLEAN | | | | | +| INT32 | | | | | +| INT64 | | | | | +| INT96 | | | | | +| FLOAT | | | | | +| DOUBLE | | | | | +| BYTE_ARRAY | | | | | +| FIXED_LEN_BYTE_ARRAY | | | | | + +### Logical types + +| Data type | C++ | Java | Go | Rust | +| ----------------------------------------- | ----- | ------ | ----- | ----- | +| STRING | | | | | +| ENUM | | | | | +| UUID | | | | | +| 8 and 16 bit signed INT | | | | | +| 8, 16, 32, 64 bit unsigned INT | | | | | +| DECIMAL (INT32) | | | | | +| DECIMAL (INT64) | | | | | +| DECIMAL (BYTE_ARRAY) | | | | | +| DECIMAL (FIXED_LEN_BYTE_ARRAY) | | | | | +| DATE | | | | | +| TIME (INT32) | | | | | +| TIME (INT64) | | | | | +| TIMESTAMP (INT32) | | | | | +| TIMESTAMP (INT64) | | | | | +| INTERVAL | | | | | Review Comment: My point is, it _is_ a logical type (which is the title of this table), just not in the `LogicalType` union (and as you noted, it's still covered in `LogicalTypes.md`). It's deprecation status is ambiguous. `ConvertedType` is deprecated, and no new types are to be added to it, but readers are still expected to be able to read and understand `ConvertedType`, and writers are still expected to populate it when a mapping exists. All this seven years after deprecation. This is well beyond scope for this PR, but it would be nice if deprecated things actually did disappear from the spec after a certain time (`INT96`, I'm looking at you 👀). Otherwise what's the point of deprecation? Perhaps listing it here, and having few (if any) implementations supporting it would provide the ammunition to kill it off once and for all. 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
