alamb commented on code in PR #69: URL: https://github.com/apache/parquet-site/pull/69#discussion_r1666629630
########## content/en/docs/File Format/metadata.md: ########## @@ -3,8 +3,8 @@ title: "Metadata" linkTitle: "Metadata" weight: 5 --- -There are three types of metadata: file metadata, column (chunk) metadata and page -header metadata. All thrift structures are serialized using the TCompactProtocol. +There are two types of metadata: file metadata, and page header metadata. All Review Comment: I recommend providing a link to precisely what these terms are referring to I think "file metadata" refers to `FileMetadata` https://github.com/apache/parquet-format/blob/ed66e87da9b2d79d6e9262fe37d5eae045c6a639/src/main/thrift/parquet.thrift#L1141 I am not sure what "page header metadata" refers to . Is it `DataPageHeader` https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L580 ? If so, maybe we could update this document to use the same terms `FileMetadata` rather than `file metadata` and `DatePageHeader` rather than `page header` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
