[
https://issues.apache.org/jira/browse/PARQUET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490992#comment-14490992
]
Cheng Lian commented on PARQUET-250:
------------------------------------
I believe this ticket duplicates PARQUET-173 and has already been fixed by [PR
#108|https://github.com/apache/incubator-parquet-mr/pull/108].
> StatisticsFilter "And"'s semantic error
> ---------------------------------------
>
> Key: PARQUET-250
> URL: https://issues.apache.org/jira/browse/PARQUET-250
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Affects Versions: 1.6.0
> Reporter: Yijie Shen
> Labels: easyfix
>
> {code}
> public Boolean visit(And and) {
> return and.getLeft().accept(this) && and.getRight().accept(this);
> }
> {code}
> visit(And and) is used to determine whether a row group "canDrop", therefore,
> in "And" situation, either left "canDrop" or right "canDrop" would lead the
> row group "canDrop", so we need a "||" here to make the choice.
> Therefore, it should be:
> {code}
> public Boolean visit(And and) {
> return and.getLeft().accept(this) || and.getRight().accept(this);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
