[
https://issues.apache.org/jira/browse/PARQUET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491337#comment-14491337
]
Yijie Shen commented on PARQUET-250:
------------------------------------
[~lian cheng] Yes, I didn't check the tickets history before I make this one,
sorry for this.
I found this error with spark's mater branch, which relies on parquet-1.6.0rc3
now, should it also be fixed?
> StatisticsFilter "And"'s semantic error
> ---------------------------------------
>
> Key: PARQUET-250
> URL: https://issues.apache.org/jira/browse/PARQUET-250
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Affects Versions: 1.6.0
> Reporter: Yijie Shen
> Labels: easyfix
>
> {code}
> public Boolean visit(And and) {
> return and.getLeft().accept(this) && and.getRight().accept(this);
> }
> {code}
> visit(And and) is used to determine whether a row group "canDrop", therefore,
> in "And" situation, either left "canDrop" or right "canDrop" would lead the
> row group "canDrop", so we need a "||" here to make the choice.
> Therefore, it should be:
> {code}
> public Boolean visit(And and) {
> return and.getLeft().accept(this) || and.getRight().accept(this);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
