+1

The sun conventions are excellent and what I've always tried to follow.
Unfortunately, not always possible when diving into an existing codebase and
a group with existing standards that are different.

Eclipse' formatting tools can be used to quickly apply most of the
guidelines at once to a file.  Very handy.

I would recommend though, that any reformats to bring source into
conformance with new conventions be done discrete of any functional
feature/bug changes.

I.E. 


1) Create a Jira issue specifically for 'code hygiene' for this task.
2) Reformat a file or files.  
3) Commit them without making any functional changes.

This way, when looking for functional differentials, they will be easy to
find and identify in diff comparisons and not masked within a ton of hygiene
changes.

Cheers,

Mel

-----Original Message-----
From: Jukka Zitting [mailto:[email protected]] 
Sent: Thursday, February 18, 2010 5:27 PM
To: [email protected]
Subject: PDFBox coding style

Hi,

Following up from a comment made in private.

I suppose I'm not the only one who finds the current PDFBox coding
style inconvenient. All the other Java projects I'm working with
follow close approximations of the classic Sun Java coding conventions
[1]. PDFBox doesn't, which makes the code harder to read and write at
least for me.

It's not too big an issue and I can certainly live with the current
coding style, but I'm wondering if there would be enough support to
consider a gradual migration to a more standard style.

[1] http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html

BR,

Jukka Zitting

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to