Hi, Am 05.04.2013 um 11:10 schrieb Andreas Lehmkühler <[email protected]>:
> Hi, > > Thomas Chojecki <[email protected]> hat am 5. April 2013 um 10:31 > geschrieben: >> Am 05.04.2013 07:45, schrieb Andreas Lehmkuehler: >>> Hi, >> Hi, >> >>> Am 04.04.2013 20:53, schrieb Thomas Chojecki: >>>> Hi all, >>>> I have patched the COSWriter and I would ask you to test it please. I >>>> attached >>>> the patch. >>> Thanks for jumping in. Looks good to me, it restores the old >>> behaviour. I'll run >>> some additional tests at the weekend. BTW the written trailer isn't >>> correct in >>> any case. If the origin trailer contains a xrefstream, some of the >>> stream >>> information (the decodeparms, the type) is still there. But that's not >>> new, >>> 1.7.1 already did the same. >> doesn't notice that the trailer keep this informations. I've already >> started to port the xref stream writer for new created or altered >> documents. This should fix this trailer issue too. But at the moment it >> doesn't work as expected. > IMHO this isn't urgent, as it works for years now ;-) > Agree that this doesn't need an immediate fix. For a general fix maybe that should be part of a PDFBOX 2 discussion e.g. instead of patching here and there maybe some of pdfbox current architecture and approach needs some revisiting. >>> I'll cut a new release soon, if everythings works well and nobody >>> objects. >> Thanks and sorry for the extra work. > No need to worry. > >>>> Due to temp. lacking access to my apache webspace, I uploaded the >>>> patched jar on >>>> my private server. >>>> >>>> http://media-nation.de/~rayman2200/pdfbox-1.9.0-SNAPSHOT.jar >>>> >>>> Best regards >>>> Thomas >>>> >>>> If no one complain I would commit it. >>> +1, please use PDFBOX-1551 as reference. >> Ok, but I will not be able to edit or close issues. Maybe you know who >> is the right contact for fixing jira issue privileges? > My bad, I simply forgot to add you to the committer role after becoming a > committer. I should work now. > >> Best regards >> Thomas > > BR > Andreas Lehmkühler thanks Thomas for the quick fix. BR Maruan
