[
https://issues.apache.org/jira/browse/PDFBOX-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687821#comment-13687821
]
Maruan Sahyoun commented on PDFBOX-1645:
----------------------------------------
Hi Robert,
I do like the additional checks you have put in and I can see why they are
included. What might be missing is how to deal with fonts which are not correct
and don't fail because of the changes. As you suggested at least there should
be a warning so people are aware of the fact. In addition there are some
assumptions in your code about the number of parameters where you put checks in
[if (numbers.size() - i >= 6)] but there might be numbers other than multiplies
of 6 which are overseen as the iteration is done by 6. So maybe some of the
checks could be moved to an earlier point for general parameter checking,
reporting if needed and further processing.
WDYT
BR
Maruan
> [PATCH] Improved the accuracy of the bounding box for each rendered CFF glyph
> -----------------------------------------------------------------------------
>
> Key: PDFBOX-1645
> URL: https://issues.apache.org/jira/browse/PDFBOX-1645
> Project: PDFBox
> Issue Type: Improvement
> Components: FontBox
> Affects Versions: 1.8.2
> Reporter: Robert Meyer
> Fix For: 2.0.0
>
> Attachments: patch.diff
>
>
> In a previous patch to the CharStringRenderer class, I resolved the rendering
> issues and added a method to retrieve the bounding box for a CFF glyph. This
> utilized the GeneralPath.getBounds() method to retrieve it's bounding box.
> Unfortunately it was found that the method uses the control points of the
> bezier curves instead of the actual lines and was not very accurate. I have
> therefore added several new methods to calculate the correct extents of the
> glyph so that now it matches that of the measurements found in tools like
> FontForge.
> As a side note, there are several checks which were originally added in my
> patch which were unfortunately removed relating to the number of arguments
> provided with an operator. I have one Adobe Font (Adobe Heiti Standard -
> CID-Keyed OTF) which has one or more glyphs which trip up on this and cause
> an Array index out of Bounds exception. Each glyph renders correctly even
> though this issue occurs and therefore would be grateful if these could be
> left in. I have re-added these checks back with the patch I am about to add.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
