THausherr commented on PR #532: URL: https://github.com/apache/pdfbox/pull/532#issuecomment-5694803537
I did a fast (human) visual compare by scrolling through the diff files. Besides the one chinese file that the issue is about, many were slightly different but the few where I had a closer look didn't seem to have any problem, one was slightly better, the horizontal bar in an "e" was more in the middle than without hinting. The rendering with hinting was faster (which is surprising, we'll see if this keeps happening) One difference has less quality: https://github.com/mozilla/pdf.js/issues/1732 file: [PDFJS-1732.pdf](https://github.com/user-attachments/files/32279279/PDFJS-1732.pdf) new rendering at 96 dpi (third line): <img width="254" height="44" alt="grafik" src="https://github.com/user-attachments/assets/1edbc029-75f8-4541-8cba-4e59636f85d1"; /> old rendering: <img width="252" height="49" alt="grafik" src="https://github.com/user-attachments/assets/fb8a628c-5c47-4348-8fac-bf704b37e284"; /> another file also caught my attention: [genko_oc_shiryo1.pdf](https://github.com/user-attachments/files/32279678/genko_oc_shiryo1.pdf) the new rendering looks partly bold. Another small thing: IMHO the setting should be in PDFRenderer, not in TrueType. This can be done like `setSubsamplingAllowed`, and passed to `PageDrawerParameters`, then to `PageDrawer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
