pcorless commented on PR #532: URL: https://github.com/apache/pdfbox/pull/532#issuecomment-5709043055
I'll start working through those copilot comments. Performance is an interesting one. On my test suite I also see no penalty for having hinting enabled. The caching works really well for most fonts. I referenced pdf.js on my initial research as I thought it would be a good reference. As I dug in though it turned out their hinting was coming from a native system library not from JavaScript. The two sample files you posted both fall into the "tricky" fonts category. FreeType has identified a list of fonts that need to be handled as [special case.](https://github.com/pcorless/pdfbox/blob/PDFBOX-3293.truetype.hinting.submit/fontbox/src/main/java/org/apache/fontbox/ttf/GlyphHinter.java#L368) Differently being they need the bytecode to assembled/scale the glpyhs on every size. FreeTypes license is pretty flexible so I suspect it can be tied back in but it will take some legal work to properly update the LICENSE and NOTICE files. Pushed changes for your two comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
