[ https://issues.apache.org/jira/browse/PDFBOX-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607143#comment-14607143 ]
Jim deVos edited comment on PDFBOX-2847 at 6/30/15 4:41 AM: ------------------------------------------------------------ I attached a patch for r1686617 on /branches/1.8 that has a potential fix for the bug as well as a tweaked version of the mergeDocumentsNonSeq() test. Apologies in advance - this is my first bug report and my first patch so I probably screwed up many aspects of the protocol / code style for these types of reports. was (Author: jtdevos): This is a patch for r1686617 on /branches/1.8 that has a potential fix for the bug as well as a tweaked version of the mergeDocumentsNonSeq() test. Apologies in advance - this is my first bug report and my first patch so I probably screwed up many aspects of the protocol / code style for these types of reports. > mergeDocumentsNonSeq does not utilize scratchFile > ------------------------------------------------- > > Key: PDFBOX-2847 > URL: https://issues.apache.org/jira/browse/PDFBOX-2847 > Project: PDFBox > Issue Type: Bug > Components: Utilities > Affects Versions: 1.8.9 > Reporter: Jim deVos > Attachments: pdfbox1.8.x.patch > > > I noticed when merging relatively large pdfs (1gb) that the heap would grow > by at least the same amount until complete, even when I call > mergeDocumentsNonSeq() and supplying a read/write scratchfile. > When I looked at the source for mergeDocuments(bool, RandomAccess), it looks > like the scratch file is never used. > {code} > private void mergeDocuments(boolean isNonSeq, RandomAccess scratchFile) > throws IOException, COSVisitorException > { > //...snip > if (isNonSeq) > { > source = PDDocument.loadNonSeq(sourceFile, null); > } > //...snip > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org