[ https://issues.apache.org/jira/browse/PDFBOX-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607878#comment-14607878 ]
Tilman Hausherr edited comment on PDFBOX-2847 at 6/30/15 9:35 AM: ------------------------------------------------------------------ Thanks, I committed that, with an expanded test, i.e. that both get tested. I'll also add the use of a scratch file into the 2.0 version. was (Author: tilman): Thanks, I committed that, with an expanded test, i.e. that both get tested. > mergeDocumentsNonSeq does not utilize scratchFile > ------------------------------------------------- > > Key: PDFBOX-2847 > URL: https://issues.apache.org/jira/browse/PDFBOX-2847 > Project: PDFBox > Issue Type: Bug > Components: Utilities > Affects Versions: 1.8.9 > Reporter: Jim deVos > Assignee: Tilman Hausherr > Attachments: pdfbox1.8.x.patch > > > I noticed when merging relatively large pdfs (1gb) that the heap would grow > by at least the same amount until complete, even when I call > mergeDocumentsNonSeq() and supplying a read/write scratchfile. > When I looked at the source for mergeDocuments(bool, RandomAccess), it looks > like the scratch file is never used. > {code} > private void mergeDocuments(boolean isNonSeq, RandomAccess scratchFile) > throws IOException, COSVisitorException > { > //...snip > if (isNonSeq) > { > source = PDDocument.loadNonSeq(sourceFile, null); > } > //...snip > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org