[
https://issues.apache.org/jira/browse/PDFBOX-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295503#comment-15295503
]
Tilman Hausherr commented on PDFBOX-3353:
-----------------------------------------
Some thoughts:
- PDSquareAnnotationTest.java tests itself, i.e. it tests a file that is
already there, not a file where the appearance stream is missing
- you used a different strategy in the square annotation handler to create the
AP than I did... yours is probably better, as it requires less calculations in
the code
- something must be done about that double content stream code, that would be
the "shared implementation" you mention
- appearance handlers should have some common code in the base class.
{{generateNormalAppearance}} has only 3 lines that are specific for this
annotation, all the rest could be common
- why is the PDAppearanceContentStream separated from the PDDocument, i.e. not
using any scratch file settings from it? Could this become a problem or is this
not relevant?
- why is that formatDecimal important?
> Create appearance streams for annotations
> -----------------------------------------
>
> Key: PDFBOX-3353
> URL: https://issues.apache.org/jira/browse/PDFBOX-3353
> Project: PDFBox
> Issue Type: Task
> Components: PDModel, Rendering
> Affects Versions: 1.8.12, 2.0.0, 2.0.1, 2.0.2, 2.1.0
> Reporter: Tilman Hausherr
> Labels: Annotations
> Attachments: showAnnotation.java
>
>
> Create appearance streams for annotations when missing.
> I'll start by replacing current code for Ink and Link annotations.
> Good example PDFs:
> http://www.pdfill.com/example/pdf_commenting_new.pdf
> https://github.com/mozilla/pdf.js/issues/6810
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
