[ https://issues.apache.org/jira/browse/PDFBOX-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034714#comment-17034714 ]
Maruan Sahyoun commented on PDFBOX-4723: ---------------------------------------- [~capSVD] I've partially reverted the change in the 2.0 branch and am no longer targeting 2.0.19 as we plan to cut a release. Note that I will continue the work on trunk. With regards to your above mentioned test. Maybe you can provide a simple unit test which we can incorporate as to make sure to not break the correct inserting/removing of pages. > Add equals() and hashCode() to PDAnnotation and COS objects > ----------------------------------------------------------- > > Key: PDFBOX-4723 > URL: https://issues.apache.org/jira/browse/PDFBOX-4723 > Project: PDFBox > Issue Type: Sub-task > Components: PDModel > Affects Versions: 2.0.18 > Reporter: Maruan Sahyoun > Assignee: Maruan Sahyoun > Priority: Major > Fix For: 3.0.0 PDFBox > > > In order to proper support removeAll/retainAll for COSArrayList we need to > detect if entries are in fact duplicates of others. This currently fails as > even though one might add the same instance of an annotation object multiple > times to setAnnotations getting the annotations will have individual > instances. See the discussion at PDFBOX-4669. > In order to proper support removal we need to be able to detect equality > where an object is equal if the underlying COSDictionary has the same entries. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org