[ 
https://issues.apache.org/jira/browse/PDFBOX-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133175#comment-17133175
 ] 

Andreas Lehmkühler commented on PDFBOX-4877:
--------------------------------------------

[~Faltiska] I've committed an improved version of your proposal as your patch 
would have changed some of the behaviour:

* multiply still does allow the second operator to be null
* the new Constructor using an float array is private
* the single float array is still private
* the result check is still intact

The interesting part is, that the most effective change was to move the float 
array multiplication to a separate method. 

> Matrix class performance improvements
> -------------------------------------
>
>                 Key: PDFBOX-4877
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4877
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing, Text extraction
>    Affects Versions: 2.0.20, 3.0.0 PDFBox
>            Reporter: Alfred
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>              Labels: Optimization
>         Attachments: PDFBOX-4877.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> I am testing text extraction from PDF and profiling the execution.
> I found that the third major time consumer is with matrix multiplicaitons.
> The Matrix class spends large amounts of time copying results to new 
> instances. 
> Also, the if statements are slowing down execution as they kill performance 
> in modern CPUs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to