[ https://issues.apache.org/jira/browse/PDFBOX-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213301#comment-17213301 ]
Maruan Sahyoun commented on PDFBOX-4987: ---------------------------------------- Although internally used I'd go for an enum as we have a distinct set of values if we follow [~ssteiner] suggestion. Has other benefits too. > CharStringCommand should use referenced string > ---------------------------------------------- > > Key: PDFBOX-4987 > URL: https://issues.apache.org/jira/browse/PDFBOX-4987 > Project: PDFBox > Issue Type: Improvement > Components: Parsing > Reporter: Simon Steiner > Priority: Major > > CharStringCommand, Type2CharString and Type1CharString use duplicate string > instances, could they use enum or final strings so its easier to debug the > code > eg > static final x =new key(1, {color:#008000}"hstem");{color} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org