[ 
https://issues.apache.org/jira/browse/PDFBOX-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219746#comment-17219746
 ] 

Andreas Lehmkühler commented on PDFBOX-4987:
--------------------------------------------

[~ssteiner], [~msahyoun] I've replaced the strings with enums. Does this meet 
your expectation?

BTW, would it be save to commit this to the 2.0 branch as well w.r.t. binary 
compatibility?

> CharStringCommand should use referenced string
> ----------------------------------------------
>
>                 Key: PDFBOX-4987
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4987
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Parsing
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Simon Steiner
>            Assignee: Andreas Lehmkühler
>            Priority: Major
>             Fix For: 3.0.0 PDFBox
>
>
> CharStringCommand, Type2CharString and Type1CharString use duplicate string 
> instances, could they use enum or final strings so its easier to debug the 
> code
> eg
> static final x =new key(1, {color:#008000}"hstem");{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to