[ https://issues.apache.org/jira/browse/PDFBOX-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257857#comment-17257857 ]
Ralf Hauser commented on PDFBOX-5067: ------------------------------------- Thanks for the feedback I tested it on the basis of CreateVisibleSignature2.java ( also with setupMixed 15MB ) It needed 8 MB more Xmx (==> 69m). But PDDocument was only loaded once, so in this case, the getter is not used. Although when you close PDVisibleSignDesigner it would be deallocated anyway. > Some of the constructors set that field, some don't (the one that calls > {{calculatePageSizeFromStream}}) I only added it where the test did a Loader.loadPDF() - there may well be more places it could be added. But still, I assume it is quicker and not that worse for the memory if the load only happens once. > make PDVisibleSignDesigner memory aware > --------------------------------------- > > Key: PDFBOX-5067 > URL: https://issues.apache.org/jira/browse/PDFBOX-5067 > Project: PDFBox > Issue Type: Improvement > Components: Signing > Affects Versions: 2.0.23 > Reporter: Ralf Hauser > Priority: Major > Attachments: patch_PDFBOX-2512.txt > > > PDFBOX-2512 might have failed earlier if I hadn't used > MemoryUsageSetting.setupMixed(15000000) > to limit the memory usage of PDDocument document to 15 MB in > CreateVisibleSignature in > > a) setVisibleSignDesigner() and used the now memory-aware constructor of > PDVisibleSignDesigner > and > b) in signPDF(), reused PDDocument > setTsaUrl(tsaUrl); > PDDocument doc = null; > if (null != visibleSignDesigner) { > doc = visibleSignDesigner.getDocument(); > } > if (null == doc) { > doc = Loader.loadPDF(inputFile, memoryUsageSetting); > } > // creating output document and prepare the IO streams. > ... > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org