[ https://issues.apache.org/jira/browse/PDFBOX-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260279#comment-17260279 ]
Tilman Hausherr commented on PDFBOX-5067: ----------------------------------------- Why must the two fields be protected? CreateVisibleSignature.java isn't meant as part of the library, it is a source code example for people to create their own signing tool. Some parts may not be useful for all users, e.g. certify. > make PDVisibleSignDesigner memory aware > --------------------------------------- > > Key: PDFBOX-5067 > URL: https://issues.apache.org/jira/browse/PDFBOX-5067 > Project: PDFBox > Issue Type: Improvement > Components: Signing > Affects Versions: 2.0.23 > Reporter: Ralf Hauser > Priority: Major > Attachments: patch5067_CreateVisibleSignature.txt, > patch_PDFBOX-2512.txt, patch_PDFBOX-5067.txt > > > PDFBOX-2512 might have failed earlier if I hadn't used > MemoryUsageSetting.setupMixed(15000000) > to limit the memory usage of PDDocument document to 15 MB in > CreateVisibleSignature in > > a) setVisibleSignDesigner() and used the now memory-aware constructor of > PDVisibleSignDesigner > and > b) in signPDF(), reused PDDocument > setTsaUrl(tsaUrl); > PDDocument doc = null; > if (null != visibleSignDesigner) { > doc = visibleSignDesigner.getDocument(); > } > if (null == doc) { > doc = Loader.loadPDF(inputFile, memoryUsageSetting); > } > // creating output document and prepare the IO streams. > ... > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org