[
https://issues.apache.org/jira/browse/PDFBOX-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797430#comment-17797430
]
Axel Howind commented on PDFBOX-5731:
-------------------------------------
PS [~lehmi]: If these constants were not retained, the tests would also fail at
once - I tried it yesterday to see what the actual effect of caching the
instances is. I removed both maps and had getPDFName() create a new instance
every time. The tests failed. This was surprising to me because it would mean
that there's a problem with equals()/hashCode(). But that's not it. The problem
is that in many places, COSName instances are compared using operator ==
instead of equals().
> org.apache.pdfbox.cos.COSName#nameMap There is a memory leak problem.
> ---------------------------------------------------------------------
>
> Key: PDFBOX-5731
> URL: https://issues.apache.org/jira/browse/PDFBOX-5731
> Project: PDFBox
> Issue Type: Bug
> Affects Versions: 2.0.30, 3.0.1 PDFBox
> Reporter: liu
> Priority: Major
> Attachments: COSName.java,
> PDFBOX-5731_clear_out_unused_COSName_instances_automatically_PDFBOX2.patch,
> PDFBox5731_clear_out_unused_COSName_instances_automatically_PDFBOX3.patch,
> attempted_fix_for_PDFBOX-5731__clear_out_unused_COSName_instances_automatically.patch,
>
> attempted_fix_for_PDFBOX-5731__clear_out_unused_COSName_instances_automatically_2.patch,
>
> attempted_fix_for_PDFBOX-5731__clear_out_unused_COSName_instances_automatically_using_cleaner.patch,
> image-2023-12-08-16-02-12-293.png, image-2023-12-13-17-04-22-073.png,
> image-2023-12-14-18-10-14-278.png, screenshot-1.png, screenshot-2.png,
> screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png,
> screenshot-8.png
>
>
> !image-2023-12-08-16-02-12-293.png!
> !screenshot-1.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
