cinsttool commented on PR #188: URL: https://github.com/apache/pdfbox/pull/188#issuecomment-2029482338
> I'm undecided about the first one, I like the second, I don't like the third one because the code looks much more complex. I assume you're hard-coding the usage of the 3-set. Yes, we only evaluate container usage patterns from a performance perspective. For example, regarding the third one, we consider that using a container solely to obtain a size instead of persistently storing and managing objects may be too costly. However, the modification we provided may indeed be less concise and clear compared to the original implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
