cinsttool commented on PR #188: URL: https://github.com/apache/pdfbox/pull/188#issuecomment-2029547059
> > I'm undecided about the first one, I like the second, I don't like the third one because the code looks much more complex. I assume you're hard-coding the usage of the 3-set. > > Yes, we only evaluate container usage patterns from a performance perspective. For example, regarding the third one, we consider that using a container solely to obtain a size instead of persistently storing and managing objects may be too costly. However, the modification we provided may indeed be less concise and clear compared to the original implementation. Maybe we can set initial capacity of the set to 3 that can save memory consumption while maintain the usage of the 3-set as the original implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
