empiredan commented on code in PR #1146:
URL: https://github.com/apache/incubator-pegasus/pull/1146#discussion_r964759538
##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -246,7 +246,31 @@ void meta_backup_engine::on_backup_reply(const error_code
err,
}
}
- // TODO(heyuchen): handle other status
+ if (response.status == backup_status::UPLOADING) {
Review Comment:
Should we use `else if` instead ?
##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -259,6 +283,48 @@ void meta_backup_engine::on_backup_reply(const error_code
err,
retry_backup(pid);
}
+// ThreadPool: THREAD_POOL_DEFAULT
+void meta_backup_engine::complete_backup()
+{
+ std::string remote_backup_dir =
+ get_backup_path(get_backup_root(FLAGS_cold_backup_root,
_cur_backup.backup_path),
+ _cur_backup.app_name,
+ _cur_backup.app_id,
+ _cur_backup.backup_id);
+ app_backup_info backup_info;
+ backup_info.app_id = _cur_backup.app_id;
+ backup_info.app_name = _cur_backup.app_name;
+ backup_info.backup_id = _cur_backup.backup_id;
+ backup_info.start_time_ms = _cur_backup.start_time_ms;
+ const auto end_time_ms = dsn_now_ms();
+ backup_info.end_time_ms = end_time_ms;
+ blob buf = json::json_forwarder<app_backup_info>::encode(backup_info);
+ error_code err = write_backup_file(remote_backup_dir,
backup_constant::BACKUP_INFO, buf);
Review Comment:
```suggestion
const auto err = write_backup_file(remote_backup_dir,
backup_constant::BACKUP_INFO, buf);
```
##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -259,6 +283,48 @@ void meta_backup_engine::on_backup_reply(const error_code
err,
retry_backup(pid);
}
+// ThreadPool: THREAD_POOL_DEFAULT
+void meta_backup_engine::complete_backup()
+{
+ std::string remote_backup_dir =
+ get_backup_path(get_backup_root(FLAGS_cold_backup_root,
_cur_backup.backup_path),
+ _cur_backup.app_name,
+ _cur_backup.app_id,
+ _cur_backup.backup_id);
+ app_backup_info backup_info;
+ backup_info.app_id = _cur_backup.app_id;
+ backup_info.app_name = _cur_backup.app_name;
+ backup_info.backup_id = _cur_backup.backup_id;
+ backup_info.start_time_ms = _cur_backup.start_time_ms;
+ const auto end_time_ms = dsn_now_ms();
Review Comment:
```suggestion
const auto end_time_ms = static_cast<int64_t>(dsn_now_ms());
```
##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -246,7 +246,31 @@ void meta_backup_engine::on_backup_reply(const error_code
err,
}
}
- // TODO(heyuchen): handle other status
+ if (response.status == backup_status::UPLOADING) {
+ ddebug_f(
+ "backup_id({}): backup for partition {} from server {} is
uploading, progress = {}",
+ _cur_backup.backup_id,
+ pid.to_string(),
+ primary.to_string(),
+ response.upload_progress);
+ }
+
+ if (response.status == backup_status::SUCCEED) {
Review Comment:
The same
##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -259,6 +283,48 @@ void meta_backup_engine::on_backup_reply(const error_code
err,
retry_backup(pid);
}
+// ThreadPool: THREAD_POOL_DEFAULT
+void meta_backup_engine::complete_backup()
+{
+ std::string remote_backup_dir =
+ get_backup_path(get_backup_root(FLAGS_cold_backup_root,
_cur_backup.backup_path),
+ _cur_backup.app_name,
+ _cur_backup.app_id,
+ _cur_backup.backup_id);
+ app_backup_info backup_info;
+ backup_info.app_id = _cur_backup.app_id;
+ backup_info.app_name = _cur_backup.app_name;
+ backup_info.backup_id = _cur_backup.backup_id;
+ backup_info.start_time_ms = _cur_backup.start_time_ms;
+ const auto end_time_ms = dsn_now_ms();
+ backup_info.end_time_ms = end_time_ms;
+ blob buf = json::json_forwarder<app_backup_info>::encode(backup_info);
Review Comment:
```suggestion
const auto buf =
json::json_forwarder<app_backup_info>::encode(backup_info);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
