hycdong commented on code in PR #1146:
URL: https://github.com/apache/incubator-pegasus/pull/1146#discussion_r966655678
##########
src/rdsn/src/meta/meta_backup_engine.cpp:
##########
@@ -246,7 +246,31 @@ void meta_backup_engine::on_backup_reply(const error_code
err,
}
}
- // TODO(heyuchen): handle other status
+ if (response.status == backup_status::UPLOADING) {
+ ddebug_f(
+ "backup_id({}): backup for partition {} from server {} is
uploading, progress = {}",
+ _cur_backup.backup_id,
+ pid.to_string(),
+ primary.to_string(),
+ response.upload_progress);
+ }
+
+ if (response.status == backup_status::SUCCEED) {
+ ddebug_f("backup_id({}): backup for partition {} from server {}
succeed",
Review Comment:
I think it is better to seperate them, you can reference the whole function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
