acelyc111 commented on code in PR #1378:
URL:
https://github.com/apache/incubator-pegasus/pull/1378#discussion_r1126743983
##########
src/runtime/ranger/ranger_resource_policy.h:
##########
@@ -42,16 +43,22 @@ enum class access_type : uint8_t
KControl = 1 << 6
};
-extern access_type operator|(access_type lhs, access_type rhs);
+access_type operator|(access_type lhs, access_type rhs);
-extern access_type operator&(access_type lhs, access_type rhs);
+access_type operator&(access_type lhs, access_type rhs);
+
+access_type &operator|=(access_type &lhs, access_type rhs);
+
+uint8_t access_type_to_int8_t(const access_type &ac_type);
// Ranger policy data structure
struct policy_item
{
- access_type access_types;
+ uint8_t access_types;
Review Comment:
```suggestion
uint8_t access_types = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
