acelyc111 commented on code in PR #1378:
URL:
https://github.com/apache/incubator-pegasus/pull/1378#discussion_r1131104049
##########
src/common/json_helper.h:
##########
@@ -347,8 +347,8 @@ inline bool json_decode(const JsonObject &in,
dsn::ranger::access_type &t)
{
dverify(in.IsUint64());
auto ans = in.GetUint64();
- auto act_min = static_cast<uint64_t>(dsn::ranger::access_type_min);
- auto act_max = static_cast<uint64_t>(dsn::ranger::access_type_max);
+ auto act_min = static_cast<uint64_t>(dsn::ranger::kAccessTypeMin);
Review Comment:
Maybe use 'empty'/'none' and 'full'/'all' instead of 'min' and 'max'? The
first sight of min and max looks like the value of access_type, i.e. kInvalid
and kControl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
