empiredan commented on code in PR #1583:
URL:
https://github.com/apache/incubator-pegasus/pull/1583#discussion_r1335369223
##########
thirdparty/CMakeLists.txt:
##########
@@ -329,7 +329,6 @@ ExternalProject_Add(curl
--disable-smtp
--disable-telnet
--disable-tftp
- --disable-shared
Review Comment:
Originally, referencing libcurl into pegasus shell directly would lead to
[hidden symbol XXX in YYY is referenced by DSO
...](https://stackoverflow.com/questions/23696585/what-does-exactly-the-warning-mean-about-hidden-symbol-being-referenced-by-dso):
This error could be eliminated by introducing http client. However,
compilation failed for macOS:
```
Undefined symbols for architecture x86_64:
"_nghttp2_is_fatal", referenced from:
_on_frame_recv in libcurl.a(libcurl_la-http2.o)
_Curl_http2_switched in libcurl.a(libcurl_la-http2.o)
_http2_recv in libcurl.a(libcurl_la-http2.o)
_http2_send in libcurl.a(libcurl_la-http2.o)
"_nghttp2_pack_settings_payload", referenced from:
_Curl_http2_request_upgrade in libcurl.a(libcurl_la-http2.o)
"_nghttp2_priority_spec_init", referenced from:
_h2_pri_spec in libcurl.a(libcurl_la-http2.o)
"_nghttp2_session_callbacks_del", referenced from:
_Curl_http2_init in libcurl.a(libcurl_la-http2.o)
"_nghttp2_session_callbacks_new", referenced from:
_Curl_http2_init in libcurl.a(libcurl_la-http2.o)
```
Then after libcurl was bumped to 8.3.0 from 7.47.0, compilation failed for
ubuntu:
```
/opt/rh/devtoolset-7/root/usr/libexec/gcc/x86_64-redhat-linux/7/ld:
/data/sa_cluster/src/empiredan-pegasus-new/thirdparty/output/lib/libcurl.a(libcurl_la-content_encoding.o):
undefined reference to symbol 'ZSTD_isError'
//lib/libzstd.so.1.3.7: error adding symbols: DSO missing from command line
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
