empiredan commented on code in PR #1583:
URL:
https://github.com/apache/incubator-pegasus/pull/1583#discussion_r1335369223
##########
thirdparty/CMakeLists.txt:
##########
@@ -329,7 +329,6 @@ ExternalProject_Add(curl
--disable-smtp
--disable-telnet
--disable-tftp
- --disable-shared
Review Comment:
Originally, referencing libcurl into pegasus shell directly would lead to
[hidden symbol XXX in YYY is referenced by DSO
...](https://stackoverflow.com/questions/23696585/what-does-exactly-the-warning-mean-about-hidden-symbol-being-referenced-by-dso):
This error could be eliminated by introducing http client. Thus
`--disable-shared` could be reserved. However, there are some other compilation
errors for macOS and bumped version 8.3.0 of libcurl, for details please see
comment below for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
