acelyc111 commented on code in PR #1914: URL: https://github.com/apache/incubator-pegasus/pull/1914#discussion_r1503560900
########## src/zookeeper/zookeeper_session.cpp: ########## @@ -24,35 +24,55 @@ * THE SOFTWARE. */ +#include <sasl/sasl.h> #include <stdlib.h> #include <zookeeper/zookeeper.h> #include <algorithm> #include <utility> #include "runtime/app_model.h" #include "runtime/rpc/rpc_address.h" +#include "utils/filesystem.h" #include "utils/flags.h" #include "utils/fmt_logging.h" +#include "utils/strings.h" #include "zookeeper/proto.h" #include "zookeeper/zookeeper.jute.h" #include "zookeeper_session.h" DSN_DECLARE_bool(enable_zookeeper_kerberos); -DSN_DEFINE_string(security, Review Comment: It's better to keep these configs, `sasl_service_name` and `sasl_service_fqdn` are acceptable to be added as well. You can: 1. Check `zookeeper_kerberos_service_name` and `zookeeper_sasl_service_fqdn` must be empty, or they are equal to `sasl_service_name/fqdn`. 2. Add "deprecated" to the description of the old configs. 3. If the old configs are not empty, log warning logs to notify that they are deprecated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
