GehaFearless commented on code in PR #1914: URL: https://github.com/apache/incubator-pegasus/pull/1914#discussion_r1503576221
########## src/zookeeper/zookeeper_session.cpp: ########## @@ -24,35 +24,55 @@ * THE SOFTWARE. */ +#include <sasl/sasl.h> #include <stdlib.h> #include <zookeeper/zookeeper.h> #include <algorithm> #include <utility> #include "runtime/app_model.h" #include "runtime/rpc/rpc_address.h" +#include "utils/filesystem.h" #include "utils/flags.h" #include "utils/fmt_logging.h" +#include "utils/strings.h" #include "zookeeper/proto.h" #include "zookeeper/zookeeper.jute.h" #include "zookeeper_session.h" DSN_DECLARE_bool(enable_zookeeper_kerberos); -DSN_DEFINE_string(security, Review Comment: https://github.com/apache/incubator-pegasus/commit/966c5b831d0a6b9742aea60786c46123f4a053bd There 2 conifgs just add at last month. And there is no issue involved. Is it necessary to do this work? This leads to more difficult to read configurations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
