ninsmiracle commented on PR #1961:
URL:
https://github.com/apache/incubator-pegasus/pull/1961#issuecomment-2041994086
> > > It's OK to me to remove the periodic manual compaction function, it
can be replaced by thirdparty tools, feel free to remove it.
> >
> >
> > I think it's reasonable to keep this periodic manual compaction
function. Cause many user using spark to set manual compaction time now. If we
remove this function in new version, we have to change the change user habits.
Actully, I think we lack a unified management platform to control every things.
>
> What is "using spark to set manual compaction time" ? Is it a Pegasus
binding method? I don't think it's a block to remove the periodic manual
compaction. This is not the core tasks of Pegasus, it make the code a bit of
smelly.
>
> At least, you need to make this patch to resolve these issues mentioned
above.
In high version of
[PEGASUS-SPARK](https://github.com/pegasus-kv/pegasus-spark) , a compaction
request will be send to cluster after user call `startBulkLoad` . And I will
update PEGASUS-SPARK this week.
I do not think we should remove perodic manual compaction code now . Cause
I think all its bugs about manual compaction have been fixed, and they are all
minor issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
