ninsmiracle commented on code in PR #1961:
URL:
https://github.com/apache/incubator-pegasus/pull/1961#discussion_r1547311277
##########
src/server/pegasus_server_impl.cpp:
##########
@@ -3375,12 +3389,17 @@ uint64_t pegasus_server_impl::do_manual_compact(const
rocksdb::CompactRangeOptio
// update rocksdb statistics immediately
update_replica_rocksdb_statistics();
- uint64_t last_manual_compact_finish_time = 0;
- CHECK_OK_PREFIX(
-
_meta_store->get_last_manual_compact_finish_time(&last_manual_compact_finish_time));
return last_manual_compact_finish_time;
}
+void pegasus_server_impl::after_manual_compact(std::uint64_t starttime,
uint64_t endtime)
+{
+ // store last manual compact used time to meta store for learn situation
Review Comment:
I think this patch will still work. Cause if replica server shutdown before
the replicas complete the manual compaction,the
`last_manual_compact_finish_time` would not be update. So it will start
compaction again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
