acelyc111 commented on code in PR #2164: URL: https://github.com/apache/incubator-pegasus/pull/2164#discussion_r1871547175
########## src/utils/strings.h: ########## @@ -62,6 +73,10 @@ bool iequals(const char *lhs, const std::string &rhs, size_t n); // Decide whether the first n bytes of two memory areas are equal, even if one of them is NULL. bool mequals(const void *lhs, const void *rhs, size_t n); +error_code pattern_match(const std::string &str, Review Comment: There is a similar implementation in `bool pegasus_server_impl::validate_filter(...)`, is it possible to unify to use it? ########## idl/utils.thrift: ########## @@ -0,0 +1,44 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +namespace cpp dsn.utils +namespace go utils +namespace java org.apache.pegasus.utils + +// How an string matches to a given pattern. Review Comment: ```suggestion // How a string matches to a given pattern. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
