empiredan commented on code in PR #2164: URL: https://github.com/apache/incubator-pegasus/pull/2164#discussion_r1872557049
########## src/utils/strings.h: ########## @@ -62,6 +73,10 @@ bool iequals(const char *lhs, const std::string &rhs, size_t n); // Decide whether the first n bytes of two memory areas are equal, even if one of them is NULL. bool mequals(const void *lhs, const void *rhs, size_t n); +error_code pattern_match(const std::string &str, Review Comment: OK, seems similar. I've added a `TODO` comment for this. And corner cases would also be checked later in case some errors occurred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
