ninsmiracle opened a new pull request, #2184:
URL: https://github.com/apache/incubator-pegasus/pull/2184
### What problem does this PR solve? <!--add issue link with summary if
exists-->
#2183
### What is changed and how does it work?
Raise the priority of load_from_private_log from LOW to COMMON.
##### Performance Testing <!-- At least one of them must be included. -->
I do some test case following:
| load/ship task priority | load_from_private_log task priority | qps |
duplicate_log_batch_bytes | plog Maximum backlog | Master cluster write delay
p99 | master/slave dup delay |
| -------------------- | -------------------------------- | ---- |
------------------------- | ----------- | ---------------- |
------------------------ |
| LOW | LOW | 8K | 4096
| 9k | 1ms | p95 127ms、p99 27473ms |
| LOW | COMMON | 8K | 4096
| 200 | 1ms | p95 101ms、p99 109ms |
| HIGH | HIGH | 8K | 4096
| 150 | 1ms | p95 107ms、p99 115ms |
| LOW | LOW | 20K | 4096
| 61K | 1.5ms | p95 139ms、p99 20506ms |
| LOW | COMMON | 20K | 4096
| 42K | 1.5ms | p95 126ms、p99 18127ms |
| LOW | COMMON | 20K | 0
| Continue to increase over time | 1.5ms | 95
10618ms、p99 303519ms |
As you see , change the priority from LOW to COMMON of
`load_from_private_log` will not t increase the online delay. And priority from
LOW to HIGH is no benefit for further speeding up duplication.
So based on the above experimental conclusions, I think this issues'
argument is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
